Merge pull request #55375 from nextcloud/fix/do-not-use-lazy-with-internal

susnux · web-flow · commit 61cf047d1b07 · 2025-09-28T23:30:42.000+02:00
fix: Do not try to create lazy ghosts for PHP internal classes
diff --git a/lib/private/AppFramework/Utility/SimpleContainer.php b/lib/private/AppFramework/Utility/SimpleContainer.php
@@ -61,7 +61,7 @@ private function buildClass(ReflectionClass $class): object {
 			/* No constructor, return a instance directly */
 			return $class->newInstance();
 		}
-		if (PHP_VERSION_ID >= 80400 && self::$useLazyObjects) {
+		if (PHP_VERSION_ID >= 80400 && self::$useLazyObjects && !$class->isInternal()) {
 			/* For PHP>=8.4, use a lazy ghost to delay constructor and dependency resolving */
 			/** @psalm-suppress UndefinedMethod */
 			return $class->newLazyGhost(function (object $object) use ($constructor): void {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ private function buildClass(ReflectionClass $class): object {`
`61`	`61`	`/* No constructor, return a instance directly */`
`62`	`62`	`return $class->newInstance();`
`63`	`63`	`}`
`64`		`- if (PHP_VERSION_ID >= 80400 && self::$useLazyObjects) {`
	`64`	`+ if (PHP_VERSION_ID >= 80400 && self::$useLazyObjects && !$class->isInternal()) {`
`65`	`65`	`/* For PHP>=8.4, use a lazy ghost to delay constructor and dependency resolving */`
`66`	`66`	`/** @psalm-suppress UndefinedMethod */`
`67`	`67`	`return $class->newLazyGhost(function (object $object) use ($constructor): void {`