Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 28, 2025

Summary

Fix a crash when an app injects a PHP internal class through DI.

Checklist

@come-nc come-nc added this to the Nextcloud 33 milestone Sep 28, 2025
@come-nc come-nc self-assigned this Sep 28, 2025
@come-nc come-nc added the 3. to review Waiting for reviews label Sep 28, 2025
@come-nc come-nc marked this pull request as ready for review September 28, 2025 12:45
@come-nc come-nc requested a review from a team as a code owner September 28, 2025 12:45
@come-nc come-nc requested review from ArtificialOwl and salmart-dev and removed request for a team September 28, 2025 12:45
@come-nc come-nc requested review from artonge and susnux September 28, 2025 13:28
@susnux susnux merged commit 61cf047 into master Sep 28, 2025
241 of 250 checks passed
@susnux susnux deleted the fix/do-not-use-lazy-with-internal branch September 28, 2025 21:30
@susnux
Copy link
Contributor

susnux commented Sep 28, 2025

was it merged in 32?

@provokateurin
Copy link
Member

/backport to stable32

@backportbot
Copy link

backportbot bot commented Sep 29, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55375/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d51efd97

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55375/stable32

Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@come-nc
Copy link
Contributor Author

come-nc commented Sep 29, 2025

/backport to stable32

@backportbot
Copy link

backportbot bot commented Sep 29, 2025

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/55375/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d51efd97

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55375/stable32

Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot make instance of internal class lazy

4 participants