Skip to content

Commit e5ba7eb

Browse files
authored
Merge pull request #38045 from nextcloud/fix/35760
Fix app overflow menu on bright color theme
2 parents 5a7c8b3 + 88f3443 commit e5ba7eb

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

core/src/components/AppMenu.vue

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,14 +247,18 @@ $header-icon-size: 20px;
247247
}
248248
249249
::v-deep .app-menu-more .button-vue--vue-tertiary {
250-
color: var(--color-primary-text);
251250
opacity: .7;
252251
margin: 3px;
253252
filter: var(--background-image-invert-if-bright);
254253
255-
&:hover {
256-
opacity: 1;
257-
background-color: transparent !important;
254+
/* Remove all background and align text color if not expanded */
255+
&:not([aria-expanded="true"]) {
256+
color: var(--color-primary-text);
257+
258+
&:hover {
259+
opacity: 1;
260+
background-color: transparent !important;
261+
}
258262
}
259263
260264
&:focus-visible {
@@ -267,6 +271,8 @@ $header-icon-size: 20px;
267271
.app-icon {
268272
position: relative;
269273
height: 44px;
274+
/* Icons are bright so invert them if bright color theme == bright background is used */
275+
filter: var(--background-invert-if-bright);
270276
271277
&.has-unread::after {
272278
background-color: var(--color-main-text);

dist/core-main.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-main.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)