Fix app overflow menu on bright color theme #38045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Pytal,
juliusknorr,
nfebe and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable26 |
This comment was marked as outdated.
This comment was marked as outdated.
nextcloud-command
force-pushed
the
fix/35760
branch
from
14adfe2 to
96ac7aa
Compare
Contributor
Author
|
/compile amend |
…u must be inverted Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/35760
branch
from
55507f5 to
88f3443
Compare
Member
|
There was a change on the coloring behaviour in the vue library recently I think. Can you check if the lib update is already in server and if not make sure it's not breaking there again? |
Contributor
Author
@nickvergessen |
Pytal
approved these changes
May 3, 2023
juliusknorr
approved these changes
May 3, 2023
1 task
Contributor
Author
|
/backport to stable25 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The background color of the popover on bright color themes is also bright, so icons (which are white) need to be inverted.
Additionally the overflow menu toggle, if active, should be visible. Currently the toggle is fixed to primary text color which might be white which collides on bright color themes as the background of the button is also a bright color.
Screenshots
Maybe you find the screen recordings helpful to see what I have changed:
Before
before.mp4
After
after.mp4
Checklist