-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed
Description
Adding users as sub-admin master branch and probably a couple of recent versions, at least v22:
server/apps/settings/src/components/UserList.vue
Lines 78 to 85 in 5a469f5
| <!-- hidden input trick for vanilla html5 form validation --> | |
| <input v-if="!settings.isAdmin" | |
| id="newgroups" | |
| :class="{'icon-loading-small': loading.groups}" | |
| :required="!settings.isAdmin" | |
| :value="newUser.groups" | |
| tabindex="-1" | |
| type="text"> |
- the comment states it is an "hidden input trick for vanilla html5 form validation", but the input is not hidden
- as long as no groups have been selected the input is empty
- if one of the sub-admin groups are selected the (not-hidden) input just shows the string "[object Object]"
So shouldn't this be changed:
- if still required as that "HTML5 form validation trick" then it should be really hidden, as it is really confusing to have this strange buggy input field in the UI
- if it is supposed to function then this "[object Object]" string value somehow does not look right and perhaps should be replaced by a comma separated list of group-ids or so
Metadata
Metadata
Assignees
Labels
No labels