Skip to content

Subadmin user-add and strange required input fields #28992

@rotdrop

Description

@rotdrop

Adding users as sub-admin master branch and probably a couple of recent versions, at least v22:

<!-- hidden input trick for vanilla html5 form validation -->
<input v-if="!settings.isAdmin"
id="newgroups"
:class="{'icon-loading-small': loading.groups}"
:required="!settings.isAdmin"
:value="newUser.groups"
tabindex="-1"
type="text">

  • the comment states it is an "hidden input trick for vanilla html5 form validation", but the input is not hidden
  • as long as no groups have been selected the input is empty
  • if one of the sub-admin groups are selected the (not-hidden) input just shows the string "[object Object]"

So shouldn't this be changed:

  • if still required as that "HTML5 form validation trick" then it should be really hidden, as it is really confusing to have this strange buggy input field in the UI
  • if it is supposed to function then this "[object Object]" string value somehow does not look right and perhaps should be replaced by a comma separated list of group-ids or so

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions