Skip to content

Rework theming logic to invert header icon color #4776

@justin-sleep

Description

@justin-sleep

The current method of determining whether or not to invert the color for header icons (after 68a63ad) is insufficient. Currently, it allows darker icons on a fairly dark background, e.g. my current theme color:

1494362061

One possible solution would be to raise the lightness threshold for inverting the colors. This is what it looks like after I raised the threshold past 55 (my background color's lightness):

1494363045

As what looks 'better' may vary from person to person, another possible solution to this would be to simply allow the user a button in the theming interface to toggle dark/light header icons.

Steps to reproduce

  1. Open theming settings
  2. Change background color to a value straddling the lightness threshold (e.g. #745CBA)

Expected behaviour

The header icon colors should not be dark.

Actual behaviour

The header icon colors invert to their dark variants.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions