Installing Nextcloud server shows a warning about missing indices

[nickvergessen]

• "systag_by_objectid" in table "systemtag_object_mapping" @ChristophWurst needs backporting to 30

  server/core/Application.php

  Lines 228 to 232 in 9f23b43

  	$event->addMissingIndex(
  	'systemtag_object_mapping',
  	'systag_by_objectid',
  	['objectid']
  	);

  
  Added in perf(systemtags): Add index for systemtags_object_mappings.objectid #45306 but was not added to the table creating migration in

  server/core/Migrations/Version13000Date20170718121200.php

  Line 732 in af6de04

  $table->addIndex(['systemtagid', 'objecttype'], 'systag_by_tagid');

• That being said, there was another index added with a normal migration for 31 cc @skjnldsv feat(systemtags): add bulk tagging action #48786 which should be moved to the passive updating as well, or this one can also be live
• "preferences_app_key" in table "preferences" @ArtificialOwl you removed the index, but the warning is still in place:

  server/core/Application.php

  Lines 204 to 208 in 9f23b43

  	$event->addMissingIndex(
  	'preferences',
  	'preferences_app_key',
  	['appid', 'configkey']
  	);

  so anyone running the command will recreate the index and we therefore need a new migration to remove it, together with removing (I prefer commenting out) in the core/Application.php

[skjnldsv]

• That being said, there was another index added with a normal migration for 31 cc @skjnldsv feat(systemtags): add bulk tagging action #48786 which should be moved to the passive updating as well, or this one can also be live

Can you give pointers please?

[nickvergessen]

Can you give pointers please?

1. Remove the index from the migration Version31000Date20241018063111
2. Add the index to the original migration that creates the table (if all columns exist) fix(db): Create the systag_by_objectid index for new installations #49677
3. Add to the "missing index" code as Christoph did with his index in perf(systemtags): Add index for systemtags_object_mappings.objectid #45306

[skjnldsv]

Can you give pointers please?

1. Remove the index from the migration Version31000Date20241018063111
2. Add the index to the original migration that creates the table (if all columns exist) fix(db): Create the systag_by_objectid index for new installations #49677
3. Add to the "missing index" code as Christoph did with his index in perf(systemtags): Add index for systemtags_object_mappings.objectid #45306

#50200