[Bug]: Internal share with Teams (circles) show teams id and not name

[Gprotin]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

When you share a folder with a Teams (circles) the displayed name is replaced by its ID on refresh and you are unable to delete the share.
Team members have access though

Steps to reproduce

1. Create a team in the app contact
2. Make an internal share on a folder with this team
3. The folder is well shared and display the team name
4. Refresh
5. The name is replaced by an ID
6. You are unable to delete the share

Expected behavior

When you share a folder with a team, it must display the team name in Internal shares and it must be possible to delete the share

Nextcloud Server version

31

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

"system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "XXXXX"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "31.0.2.1",
        "overwrite.cli.url": "https:\/\/XXXXX",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "proxy": "proxy.siginet.lu:8080",
        "maintenance": false,
        "appstoreenabled": "true",
        "skeletondirectory": "\/mnt\/XXXXXX\/accept\/data\/__groupfolders\/1",
        "overwriteprotocol": "https",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR"
        ],
        "loglevel": 0,
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "LOGIN",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "memcache.distributed": \\OC\\Memcache\\Redis,
        "memcache.locking": \\OC\\Memcache\\Redis,
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": "0",
            "dbindex": "0",
            "timeout": "1.5"
        },
        "filelocking.enabled": "true",
        "memcache.local": \\OC\\Memcache\\Redis,
        "trashbin_retention_obligation": "auto,30",
        "default_phone_region": "LU",
        "updater.release.channel": "stable",
        "theme": "",
        "maintenance_window_start": 1,
        "files.chunked_upload.max_size": 52428800

List of activated Apps

Enabled:
  - activity: 4.0.0
  - admin_audit: 1.21.0
  - app_api: 5.0.2
  - bruteforcesettings: 4.0.0
  - circles: 31.0.0
  - cloud_federation_api: 1.14.0
  - comments: 1.21.0
  - contacts: 7.0.4
  - dav: 1.33.0
  - federatedfilesharing: 1.21.0
  - files: 2.3.1
  - files_downloadlimit: 4.0.0
  - files_external: 1.23.0
  - files_pdfviewer: 4.0.0
  - files_reminders: 1.4.0
  - files_sharing: 1.23.1
  - files_trashbin: 1.21.0
  - files_versions: 1.24.0
  - groupfolders: 19.0.4
  - logreader: 4.0.0
  - lookup_server_connector: 1.19.0
  - notifications: 4.0.0
  - oauth2: 1.19.1
  - password_policy: 3.0.0
  - privacy: 3.0.0
  - profile: 1.0.0
  - provisioning_api: 1.21.0
  - registration: 2.6.0
  - related_resources: 2.0.0
  - richdocuments: 8.6.3
  - serverinfo: 3.0.0
  - settings: 1.14.0
  - sharebymail: 1.21.0
  - sharereview: 1.3.3
  - systemtags: 1.21.1
  - text: 5.0.0
  - theming: 2.6.1
  - twofactor_backupcodes: 1.20.0
  - twofactor_totp: 13.0.0-dev.0
  - updatenotification: 1.21.0
  - user_retention: 1.14.0
  - viewer: 4.0.0
  - webhook_listeners: 1.2.0
  - workflowengine: 2.13.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Additional info

No response

[susnux]

This seems to be a regression of the sidebar split, cc @nfebe

[nfebe]

Unable to reproduce on master and stable31

[Gprotin]

Hello I've just figured that this occurs only on Team Folders with the apps : groupfolders

So to reproduce the process is the following :

1. Create group folder via the app GroupFolders
2. Create a team in the app contact
3. Make an internal share on the group folder with this team
4. The folder is well shared and display the team name
5. Refresh
6. The name is replaced by an ID
7. You are unable to delete the share

Thank you

[julien-nc]

It also happens when sharing an external storage mount or any file inside an external storage.

Additional detail: The Team name is displayed correctly right after having added the share. But after a reload, the Team ID is displayed instead.

[julien-nc]

In ShareAPIController::formatShare(), for a circle share, $share->getSharedWithDisplayName() returns a different value whether the shared node is a classic file/folder or a groupfolder/external-storage.
In the first case it returns the formatted team/circle name, and for groupfolder/external-storage it returns null (and then the circle ID is used).

https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareAPIController.php#L262

@nfebe @ArtificialOwl Any idea why?