Detect if a shipped app is updated and can be updated

[MorrisJobke]

See nextcloud/docker#288

Having two app folders configure:

• /apps with all the shipped apps and the writable flag set to false
• /apps2 with the writable flag set to true to install apps via the app store

Once we publish an update of a shipped app via the app store the app is put into apps2 and does not replace the original code and thus is not properly updated.

@nickvergessen @rullzer Ideas how to fix? I would try to detect this before the update is triggered by the user or the occ upgrade script.

[nickvergessen]

I thought our code was clever enough to always load apps from the app dir where they are the newest version?!

[MorrisJobke]

I thought our code was clever enough to always load apps from the app dir where they are the newest version?!

Doesn't seem to be like that and I also haven't seen any code lately while digging through the app management code. 😕

[nickvergessen]

Found it, the following should take care of it.
Maybe we lost the track to it somewhere:

server/lib/private/legacy/app.php

Lines 437 to 477 in 96a5752

	*/
	public static function findAppInDirectories(string $appId) {
	$sanitizedAppId = self::cleanAppId($appId);
	if($sanitizedAppId !== $appId) {
	return false;
	}
	static $app_dir = [];
	if (isset($app_dir[$appId])) {
	return $app_dir[$appId];
	}
	$possibleApps = [];
	foreach (OC::$APPSROOTS as $dir) {
	if (file_exists($dir['path'] . '/' . $appId)) {
	$possibleApps[] = $dir;
	}
	}
	if (empty($possibleApps)) {
	return false;
	} elseif (count($possibleApps) === 1) {
	$dir = array_shift($possibleApps);
	$app_dir[$appId] = $dir;
	return $dir;
	} else {
	$versionToLoad = [];
	foreach ($possibleApps as $possibleApp) {
	$version = self::getAppVersionByPath($possibleApp['path']);
	if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
	$versionToLoad = array(
	'dir' => $possibleApp,
	'version' => $version,
	);
	}
	}
	$app_dir[$appId] = $versionToLoad['dir'];
	return $versionToLoad['dir'];
	//TODO - write test
	}
	}

[j-ed]

It seems that this issue ticket covers my recently reported update problem (#8938)

[nickvergessen]

Ah, I think the issue might be psr autoloading paths are not changed.
When the new version is downloaded, it is stored in the new path, and "used". But the class map is still on the old path. So when the path changes, we need to re-register autoloading and overwrite static $app_dir in the code I linked.

[MorrisJobke]

Ah, I think the issue might be psr autoloading paths are not changed.
When the new version is downloaded, it is stored in the new path, and "used". But the class map is still on the old path. So when the path changes, we need to re-register autoloading and overwrite static $app_dir in the code I linked.

Ah ... true that was there as well 🙈

[tilosp]

Related nextcloud/docker#308 nextcloud/documentation#739

[julijane]

I would like to mention as pointed out in my pull request, when the configuration below is used it actually works (at least for me in my tests).

It also makes quite some sense to have it like this, because it appears logical to the user that the first path is checked first, and of course the updated app is to be found there then. I think the "writable" flag actually is more confusing and making this unnecessary complicated. I suggest to get rid of that flag and just check the directories in the order stated and always write into the first one. Problem solved with a configuration which is intuitive and makes sense from a logical point of view.

<?php
$CONFIG = array (
  "apps_paths" => array (
      0 => array (
              "path"     => OC::$SERVERROOT."/custom_apps",
              "url"      => "/custom_apps",
              "writable" => true,
      ),
      1 => array (
              "path"     => OC::$SERVERROOT."/apps",
              "url"      => "/apps",
              "writable" => false,
      ),
  ),
);