[stable10] Add feedback for password change #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
|
@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers |
nickvergessen
changed the title
Member
Why not?! We have Password Policy also in |
Member
Author
|
@Mar1u5 because in stable10 and stable9 the ajax endpoint already translates the hint exception to a json response, this was basically a regression from "moving change password to a controller" |
Member
|
👍 |
Member
|
Works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #978
Second commit is not necessary
@Mar1u5 @LukasReschke