Skip to content

Conversation

@georgehrke
Copy link
Member

@georgehrke georgehrke commented Jul 1, 2018

fixes #1434

Todo:

  • create provisioning root collection and add apple provisioning node to it
  • tests

@georgehrke georgehrke added the 2. developing Work in progress label Jul 1, 2018
@georgehrke georgehrke force-pushed the feature/1434/provisioning_profiles_for_dav branch 3 times, most recently from 7089819 to 6a0a7cb Compare July 5, 2018 18:06
@georgehrke
Copy link
Member Author

It seems that even with the most detailed provisioning profile iOS / macOS will still look for the .well-known/caldav / .well-known/carddav file :/

https://netfuture.ch/2013/07/dealing-with-apple-mobileconfig-configuration-profiles-quirks/

@MorrisJobke @rullzer Did we fix that issue that .well-known is only installed inside the Nextcloud-folder but not in the domains root?

@MorrisJobke
Copy link
Member

We did not, because it then needs to be configured in the Webserver itself

@jospoortvliet
Copy link
Member

So that can't be 100% fixed? 😭

@MorrisJobke
Copy link
Member

@MorrisJobke @rullzer Did we fix that issue that .well-known is only installed inside the Nextcloud-folder but not in the domains root?

We have a setup check for this nowadays. So I would assume that it will work for now and provide it.

@MorrisJobke MorrisJobke force-pushed the feature/1434/provisioning_profiles_for_dav branch from 6a0a7cb to c689fd4 Compare October 19, 2018 11:48
@MorrisJobke
Copy link
Member

I rebased it. I would say, we should continue this and can improve in the future iteratively.

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 19, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
29 tasks
@MorrisJobke
Copy link
Member

@georgehrke Looks like this one will not make it in time, right? Would like to have it merged by tomorrow evening.

@MorrisJobke MorrisJobke modified the milestones: Nextcloud 15, Nextcloud 16 Nov 7, 2018
@georgehrke georgehrke self-assigned this Nov 27, 2018
@rullzer
Copy link
Member

rullzer commented Jan 11, 2019

Lets rebase and get this in. Yeah it won't work in 100% of the cases but so be it there is no way to do that.

@georgehrke
Copy link
Member Author

We should remove CalDAVPrincipalURL and CardDAVPrincipalURL, because they are not used anymore.

Will rebase, fix that and add tests next week.

@MorrisJobke
Copy link
Member

Will rebase, fix that and add tests next week.

Could you have a look at this? So we can finally merge it :)

@georgehrke georgehrke force-pushed the feature/1434/provisioning_profiles_for_dav branch from c689fd4 to 16fec60 Compare January 30, 2019 18:50
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2019
@georgehrke
Copy link
Member Author

georgehrke commented Jan 30, 2019

tl;dr of what changed:

  • added unit tests
  • enforce HTTPs. Using the profile on HTTP silently fails on macOS
  • removed principalURI and require admins to properly configure well-known.

@georgehrke
Copy link
Member Author

please review @nextcloud/mac

@rullzer
Copy link
Member

rullzer commented Jan 30, 2019

I can't test since.. well no mac...

@georgehrke for a followup PR what would be nice

1. Add a check for the well-known
2. On the groupware page detect if a user is on a Apple device and show a link

  1. add it to the mobile & desktop-section

@rullzer
Copy link
Member

rullzer commented Jan 30, 2019

@marinofaggiana it would be great if you could implement downloading and opening this in the IOS client. That way users could more easily setup their stuff.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. And tests 🎉
But I can't tests since no macOS/iOS. so. 🐘

@marinofaggiana
Copy link
Member

Looks good from my side. And tests 🎉
But I can't tests since no macOS/iOS. so. 🐘

At end of next week I prepare a test for iOS

cc @georgehrke

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works really nice 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 31, 2019
@MorrisJobke MorrisJobke merged commit 87c8a71 into master Jan 31, 2019
@MorrisJobke MorrisJobke deleted the feature/1434/provisioning_profiles_for_dav branch January 31, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

provide config profiles for OS X/macOS and iOS

6 participants