LDAP user should be able to set avatar if directory provides incompatible image #10083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Member
skjnldsv
added
4. to release
Member
Author
|
would be awesome if the backport could get in, too 🍬 #10089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general behaviour is that LDAP users can set their avatar within Nextcloud, as long as LDAP does not provide an image. What was not taken into account was when an unsupported (Avatar API accepts PNG and JPG only) or corrupt image was supplied. For instance a BMP. In that case, the generic placeholder was shown and the hint that the avatar was provided the by user backend. Expected was that users can set an avatar in that case.
(the first commit only cleans up unit tests without effective code changes, but makes the diff look big. don't be scared.)