Skip to content

Only enforce schema limits for supported apps #10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 3 commits into from
Jan 3, 2019
Merged

Only enforce schema limits for supported apps #10555

blizzz merged 3 commits into from
Jan 3, 2019

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 6, 2018

Fix #10518

@nickvergessen nickvergessen mentioned this pull request Aug 6, 2018
Closed
rullzer
rullzer reviewed Aug 6, 2018
View reviewed changes
lib/private/DB/MigrationService.php
$infoParser = new InfoParser();
$info = $infoParser->parse($appPath . '/appinfo/info.xml');
if (!isset($info['dependencies']['database'])) {
$this->checkOracle = true;
Copy link
Member

@rullzer rullzer Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so by default we check always check oracle?

Copy link
Member Author

@nickvergessen nickvergessen Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if the author did not define a db, you can install it on any. It a db is given the dependency check ensures it. So that mathes the logic here

@rullzer rullzer added this to the Nextcloud 15 milestone Aug 8, 2018
@rullzer
Copy link
Member

rullzer commented Aug 8, 2018

Lets do this properly for 15

@rullzer rullzer mentioned this pull request Aug 8, 2018
Closed
@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 2, 2018

@nickvergessen Could you please rebase to fix the conflict?

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 2, 2018
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 8, 2018 •
edited
Loading

Done, the "conflict" was f5c63d7

@nickvergessen nickvergessen force-pushed the bugfix/10518/only-check-added-items branch from bba82f1 to 9af5d4c Compare October 8, 2018 10:58
@nickvergessen nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 8, 2018
MorrisJobke
MorrisJobke approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with shipped apps 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 9, 2018

Looks like some tests fail 🙈

@nickvergessen nickvergessen force-pushed the bugfix/10518/only-check-added-items branch from 9af5d4c to cc1253a Compare October 10, 2018 08:45
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 2, 2018

Looks like some tests fail 🙈

Resolved.

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 5, 2018

@rullzer @danielkesselberg @blizzz Mind to review this one?

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 7, 2018

@nickvergessen @rullzer Should we do this now or wait for 16?

@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
Merged
29 tasks
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 7, 2018

I'm always in favor of it. but well I manually cross check that oracle still works via the notifications tests…

@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2018
Merged
24 tasks
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 13, 2018

Let's move it to 16 and merge it early this time.

@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 14, 2018

#12446 🙈

@nickvergessen nickvergessen force-pushed the bugfix/10518/only-check-added-items branch from cc1253a to 85a0e10 Compare December 17, 2018 12:52
@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 17, 2018

Rebased to re-execuite the tests, please merge soonish

@blizzz blizzz merged commit 6895230 into master Jan 3, 2019
@blizzz blizzz deleted the bugfix/10518/only-check-added-items branch January 3, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer left review comments

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 16

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @rullzer @MorrisJobke @blizzz