Check if a preview provider is available before using it #10712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
3. to review
Contributor
denismosolov
left a comment
denismosolov
left a comment
There was a problem hiding this comment.
Does this quick change require a unit test?
Else if a preview provider is registerd but not available (for example missing support in some external lib). It will do 💥. This way the providers can at least do the sanity checks required. Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
fix/noid/check_if_provider_is_available_before_use
branch
from
ec06b87 to
5b10374
Compare
rullzer
requested review from
ChristophWurst,
MorrisJobke,
blizzz and
nickvergessen
ChristophWurst
approved these changes
Aug 20, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Changes make sense, code looks good 👍
blizzz
approved these changes
Aug 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else if a preview provider is registerd but not available (for example
missing support in some external lib). It will do 💥. This way the
providers can at least do the sanity checks required.
Signed-off-by: Roeland Jago Douma [email protected]