Skip to content

Fixes more apps menu and settings/user menu positions #10723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Aug 20, 2018
Merged

Fixes more apps menu and settings/user menu positions #10723

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb8f7d
Fixes some header style issues
weeman1337 Aug 16, 2018
3bcc0e0
Header style tweaks
weeman1337 Aug 17, 2018
36dfaf0
Removes doubled styles
weeman1337 Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
width: 0;
position: absolute;
pointer-events: none;
right: 10px;
right: 22px;
Copy link
Member

@skjnldsv skjnldsv Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking the other menus.
capture d ecran_2018-08-17_15-57-15

Copy link
Member Author

@weeman1337 weeman1337 Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding!

}
}
.logo {
Expand Down Expand Up @@ -226,9 +226,10 @@
/* NAVIGATION --------------------------------------------------------------- */
nav[role='navigation'] {
display: inline-block;
width: $header-height;
width: 0;
Copy link
Member

@skjnldsv skjnldsv Aug 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fond of hacks like that, I could prefer a proper :

li#more-apps {
	z-index: 2;
}

:)

height: $header-height;
margin-left: -$header-height;
position: relative;
}

.header-left #navigation {
Expand Down