[stable13] [LDAP] The WebUI Wizard also should not assign empty config IDs #10824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 689df9a the behaviour to assign only non-empty config IDs was introduced. Only, this was only effective for CLI and OCS API. Related to #3270. The web UI creates now also a full configuration on first load. This fixes #5094. Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
bug
3. to review
Member
|
RC 1 is out -> moving to 13.0.7 |
Member
Author
|
failing tests not related |
blizzz
requested review from
ArtificialOwl,
GitHubUser4234 and
nickvergessen
Member
Author
|
reviews, pozhaluysta? 😸 |
| public function getForm() { | ||
| $helper = new Helper(\OC::$server->getConfig()); | ||
| $prefixes = $helper->getServerConfigurationPrefixes(); | ||
| if(count($prefixes) === 0) { |
Member
There was a problem hiding this comment.
Use empty in the future ;)
Member
Author
There was a problem hiding this comment.
it wouldn't be a big array in this case, still you're right.
skjnldsv
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #10820
@MorrisJobke not so serious, feel free to move to 13.0.7. This should not be a blocker.