HEIC previews as JPG rather than PNGs to save space. #10827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Steinmetz <[email protected]>
Contributor
Author
|
@MorrisJobke @rullzer this is a follow-up to #10526 changing the preview image format like we discussed. |
MorrisJobke
added
3. to review
Member
|
It looks that there are some imports missing let me see about that |
Signed-off-by: Roeland Jago Douma <[email protected]>
MorrisJobke
approved these changes
Aug 24, 2018
rullzer
approved these changes
Aug 24, 2018
Merged
steiny2k
added a commit
to steiny2k/gallery
that referenced
this pull request
Aug 27, 2018
nextcloud/server#10827 Signed-off-by: Sebastian Steinmetz <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation was based on the Bitmap class, which used ImageMagick to create png previews. As the nature of HEIC images is rather photos than illustrations it is better to create .jpg files for the preview.