Theming: Only link Entity in footer if a url is set #10875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
added
3. to review
juliusknorr
requested review from
MorrisJobke,
nickvergessen,
skjnldsv and
tobiasKaminsky
nickvergessen
approved these changes
Aug 27, 2018
Member
|
Great stuff, and so fast 🎉 |
Member
|
Without link: With link: I think, that the cloud name should still "bold", so that it is more visible, despite that it is not a link anylonger. |
fixes #10024 Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/10024/theming-footer-link
branch
from
d7ab182 to
5175e33
Compare
Member
Author
|
@tobiasKaminsky As discussed, updated it. |
juliusknorr
added
2. developing
Signed-off-by: Julius Härtl <[email protected]>
skjnldsv
approved these changes
Aug 27, 2018
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10024