Fixes the upload progress bar layout #10969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Weimann <[email protected]>
weeman1337
requested review from
MorrisJobke,
juliusknorr,
rullzer and
skjnldsv
weeman1337
added
3. to review
skjnldsv
approved these changes
Sep 3, 2018
nickvergessen
approved these changes
Sep 3, 2018
Member
|
Awesome attention to details! |
juliusknorr
approved these changes
Sep 3, 2018
Member
|
Thanks @weeman1337 Mind to create a backport pull request for the stable14 branch? |
Member
Author
|
@juliushaertl jep - will do it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery CSS adds one pixel negative margin to the upload box:
With that there is a small gap and the text doesn't align.
This removes the jQuery negative margin, so everything looks okay.
Closes #10968