Skip to content

Conversation

@patschi
Copy link
Member

@patschi patschi commented Sep 3, 2018

This PR should address PHP 7.3 deprecation errors of specific filter_var flags, see more in issue #10894.

@nickvergessen
Copy link
Member

So I guess we still need to supply the flags in 7.0-7.2,
if so just wrap the statements with a switch and call one with and one without the flag

@patschi
Copy link
Member Author

patschi commented Sep 5, 2018

Acorrding to PHP RFC: Deprecations for PHP 7.3:

As of PHP 5.2.1 FILTER_VALIDATE_URL implies FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED. Not only are these constants useless, they also create the incorrect impression that the scheme/host requirement can be disabled.

So as PHP5 is deprecated anyway and if I'm interpreting that correct, just removing the flags should do it fine.

@xf-
Copy link

xf- commented Sep 5, 2018

please consider backport to 14.0.1. This allows nextcloud instances to run without an update after the stable PHP 7.3 release on 13. December ( https://wiki.php.net/todo/php73 ). No unnecessary log entires or adjusting log level. New GC should improve speed for some tasks.

@nickvergessen nickvergessen merged commit 480783a into master Sep 13, 2018
@nickvergessen nickvergessen deleted the bugfix/10894/php73-filter_var-deprecation branch September 13, 2018 07:31
@nickvergessen
Copy link
Member

@patschi can you prepare a backport against stable14? Thanks :)

@patschi patschi restored the bugfix/10894/php73-filter_var-deprecation branch September 16, 2018 01:52
@patschi patschi deleted the bugfix/10894/php73-filter_var-deprecation branch September 16, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants