Skip to content

Fix markup and style of mentions in comments #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 9 commits into from
Sep 5, 2018
Merged

Fix markup and style of mentions in comments #11064

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9ce96f
Show avatar using "span" instead of "div"
danxuliu Sep 5, 2018
db1fce6
Remove space between avatar and user name
danxuliu Sep 5, 2018
63ab5d9
Reformat embedded HTML code to resemble HTML code
danxuliu Sep 5, 2018
be5a1fa
Ensure that the user name is shown in bold in mentions
danxuliu Sep 5, 2018
83bf309
Highlight mentions to the current user
danxuliu Sep 5, 2018
99989b3
Fix pointer cursor not shown on avatars
danxuliu Sep 5, 2018
45cde96
Remove unneeded CSS rule for mentions
danxuliu Sep 5, 2018
92bf1ce
Ensure that the avatar and the user name will be kept together
danxuliu Sep 5, 2018
bd75366
Add new line at the end of file
danxuliu Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pointer cursor not shown on avatars 
When the cursor is on an avatar wrapper the cursor is shown as a pointer
to inform the user that it can be clicked (which will either show the
contacts menu or insert a mention, depending on the case); the cursor
must be explicitly defined for the "img" element that shows the avatar
too, or otherwise the default cursor would be shown.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Sep 5, 2018
commit 99989b37ffd28f9f010f780f4456ca8709cbea5b
4 changes: 3 additions & 1 deletion apps/comments/css/comments.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,15 @@

#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser),
#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser) .avatar,
#commentsTabView .comment:not(.newCommentRow) .message .avatar-name-wrapper:not(.currentUser) .avatar img,
#commentsTabView .comment .authorRow .avatar:not(.currentUser),
#commentsTabView .comment .authorRow .author:not(.currentUser) {
cursor: pointer;
}

.atwho-view-ul .avatar-name-wrapper,
.atwho-view-ul .avatar-name-wrapper .avatar {
.atwho-view-ul .avatar-name-wrapper .avatar,
.atwho-view-ul .avatar-name-wrapper .avatar img {
cursor: pointer;
}

Expand Down