Skip to content

[stable14] Fix markup and style of mentions in comments #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 9 commits into from
Sep 20, 2018
Merged

[stable14] Fix markup and style of mentions in comments #11077

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
da75c7f
Show avatar using "span" instead of "div"
danxuliu Sep 5, 2018
3ee07ac
Remove space between avatar and user name
danxuliu Sep 5, 2018
6b7e049
Reformat embedded HTML code to resemble HTML code
danxuliu Sep 5, 2018
3c63850
Ensure that the user name is shown in bold in mentions
danxuliu Sep 5, 2018
b14425e
Highlight mentions to the current user
danxuliu Sep 5, 2018
7c851b5
Fix pointer cursor not shown on avatars
danxuliu Sep 5, 2018
e7d4d3a
Remove unneeded CSS rule for mentions
danxuliu Sep 5, 2018
2e424d8
Ensure that the avatar and the user name will be kept together
danxuliu Sep 5, 2018
51b978d
Add new line at the end of file
danxuliu Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded CSS rule for mentions 
Most of the properties of the rule are not needed for mentions, so the
rule is no longer applied to them; the only needed property was moved to
the main rule for mentions.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Sep 5, 2018
commit e7d4d3a34b404962919df21fc5f140173e13f89e
6 changes: 5 additions & 1 deletion apps/comments/css/comments.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
adding this brings them closer to the element**/
margin-top: 5px;
}
#commentsTabView .comments li .message .avatar-name-wrapper,

.atwho-view-ul * .avatar-name-wrapper,
#commentsTabView .comment .authorRow {
position: relative;
Expand All @@ -156,6 +156,10 @@
#commentsTabView .comments li .message .atwho-inserted,
#commentsTabView .newCommentForm .atwho-inserted {
.avatar-name-wrapper {
/* Make the wrapper the positioning context of its child contacts
* menu. */
position: relative;

display: inline;
vertical-align: top;
background-color: var(--color-background-dark);
Expand Down