Remove posix_getpwuid and compare only userid #11091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bugfix/11088/cannot-read-passwd
branch
from
3d03565 to
2e5d8ec
Compare
Member
|
It's okay for me. At the moment the check is only for the same owner (not group). |
weeman1337
approved these changes
Sep 6, 2018
nickvergessen
approved these changes
Sep 11, 2018
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Well, calling posix_getpwuid( twice should not result in something different for the same input, and if it is not the same input, the result is also never the same, right?
blizzz
reviewed
Sep 12, 2018
| * @return string[] The none writable directory paths inside the app root | ||
| */ | ||
| private function getAppDirsWithDifferentOwnerForAppRoot(array $currentUser, array $appRoot): array { | ||
| private function getAppDirsWithDifferentOwnerForAppRoot($currentUser, array $appRoot): array { |
Signed-off-by: Daniel Kesselberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11088
Close #11089
posix_getpwuid returns an array with information about user/group/etc. for current user. These information is not available when /etc/passwd is not readable (see https://secure.php.net/manual/en/function.posix-getpwuid.php#45994).
@weeman1337 @rullzer is it enough to compare the user id? i guess we could check the group id as well.