Added kinetic scrolling for iOS to apps dropdown menu #11111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is tested with nc14
Contributor
Author
kevin147147
changed the title
ChristophWurst
added
design
Member
|
Btw, nice pull request id 😉 |
Member
|
@kevin147147 I thought we already checked on the last pr and the kinetic scroll was already by default on the apple browsers? 🤔 |
Contributor
Author
|
Kinetic scroll is always opt in as far as i know |
Member
|
Great addition for ios yes :) |
skjnldsv
approved these changes
Sep 10, 2018
Member
|
@kevin147147 You need to sign your commit for the tests to pass :) |
MorrisJobke
approved these changes
Oct 2, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works nicely 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is tested with nc14