Use user locale as default in the template #11134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
ChristophWurst,
danxuliu,
georgehrke and
nickvergessen
skjnldsv
added
2. developing
nickvergessen
previously requested changes
Sep 10, 2018
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
locale-template-fix
branch
from
b3cb084 to
df143cb
Compare
skjnldsv
added
3. to review
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Member
Author
|
Failure unrelated |
skjnldsv
force-pushed
the
locale-template-fix
branch
from
6587665 to
9622dd7
Compare
Member
Author
|
@nickvergessen fixed |
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
locale-template-fix
branch
from
9622dd7 to
92fbb6d
Compare
nickvergessen
approved these changes
Sep 19, 2018
schiessle
approved these changes
Sep 19, 2018
Member
schiessle
left a comment
schiessle
left a comment
There was a problem hiding this comment.
looks good, beside what @nickvergessen mentioned
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
4. to release
Member
|
And now quickly backport it, so it is in 14.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11132
@georgehrke