Better shared-by info for conversations without names #11171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Ivansss
approved these changes
Sep 11, 2018
danxuliu
reviewed
Sep 12, 2018
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
I would use a different approach: when the share is formatted, if the room has no name then return the display name of the participants in the room.
That is the same done when formatting a room to show it in the room list, so the name would be consistent between the Files app and Talk, and it would also provide a name in the list of shares of the sharer; otherwise a similar change as the one in this pull request would be needed in ShareDialogShareeListView too.
The drawback is that an additional database query would be needed to get the participants of the room if it has no name... although it should not be the end of the world (hopefully :-P ).
danxuliu
approved these changes
Sep 19, 2018
MorrisJobke
deleted the
bugfix/noid/shared-by-info-for-room-shares-without-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the token was used when the room had no name:
Shared with you and the conversation gf2vh2gq by Jos