Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 13, 2018

@skjnldsv can you help? The Vue-router seems to escape the placeholders
So when you open a group which contains a slash and reload the page, it breaks.

https://localhost/index.php/settings/users/test%2Fusers
with
https://localhost/index.php/settings/users/test/users it works quite fine.

Fixes #11110

children: [
{
path: ':selectedGroup',
path: ':selectedGroup(.*)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is working fine.
We need to encode the variables in the ocs requests instead.
Request URL: https://dev.skjnldsv.com/ocs/v2.php/cloud/groups/Test/1/users/details?offset=0&limit=25&search=
Should be /ocs/v2.php/cloud/groups/Test%2F1/users/details

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the old URL works since Nextcloud 9 and should not require urlencoding all of a sudden.

@MorrisJobke
Copy link
Member

It fixes #11110, right?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 3, 2018

@MorrisJobke no idea :/

This was referenced Nov 7, 2018
@MorrisJobke
Copy link
Member

@nickvergessen @skjnldsv Mind to rebase this one?

@MorrisJobke MorrisJobke force-pushed the bugfix/2954/interaction-with-groups-containing-a-slash branch from 129317d to 1997346 Compare November 15, 2018 09:03
@MorrisJobke
Copy link
Member

Rebased and rebuild the JS assets.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 15, 2018
@MorrisJobke MorrisJobke merged commit 4bf641f into master Nov 15, 2018
@MorrisJobke MorrisJobke deleted the bugfix/2954/interaction-with-groups-containing-a-slash branch November 15, 2018 09:30
@MorrisJobke
Copy link
Member

/backport to stable14

@MorrisJobke
Copy link
Member

/backport to stable13

@backportbot-nextcloud
Copy link

The backport to stable13 failed. Please do this backport manually.

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable13 failed. Please do this backport manually.

@MorrisJobke
Copy link
Member

/backport to stable14

@backportbot-nextcloud
Copy link

The backport to stable14 failed. Please do this backport manually.

@ChristophWurst
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants