Skip to content

Conversation

@andyg5000
Copy link
Contributor

Simple fix to the example template file to make the copyright date dynamic

@splitt3r
Copy link
Contributor

splitt3r commented Sep 20, 2018

The \ should be removed too, should it? And the doc link url. And perhaps a docblock for that ^^.^And what about getLongFooter?

@andyg5000
Copy link
Contributor Author

Oh geez, good point ;) I'll review the whole file and report back :P

@MorrisJobke MorrisJobke added the 2. developing Work in progress label Sep 26, 2018
@ChristophWurst
Copy link
Member

@andyg5000 🏓 any updates? I think this is a nice fix :)

@ChristophWurst
Copy link
Member

@splitt3r if you know what's missing it would be great if you could help move this forward :)

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of enhancement and removed 2. developing Work in progress labels Jan 30, 2019
@splitt3r
Copy link
Contributor

splitt3r commented Jan 31, 2019

@ChristophWurst ready to review 👍

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Jan 31, 2019
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change makes sense 👍

@MorrisJobke
Copy link
Member

I rebased this to trigger CI again (because it was using old steps that failed).

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2019
@MorrisJobke MorrisJobke merged commit 422dd9d into nextcloud:master Feb 1, 2019
@welcome
Copy link

welcome bot commented Feb 1, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants