Allow overwrite.cli.url without trailing slash #11446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
MorrisJobke
approved these changes
Oct 2, 2018
Member
|
I just had the missing trailing slash breaking my update to 14.0.2 RC2 on my personal instance. Anything speaking against backporting it to 14 to avoid issues during upgrade on 14? @MorrisJobke @rullzer |
Member
Fine with me 👍 |
Member
|
Great. @danielkesselberg Mind to create a backport of your pull request to the stable14 branch? |
kesselb
added a commit
that referenced
this pull request
Oct 11, 2018
Signed-off-by: Daniel Kesselberg <[email protected]>
|
Thanks for the good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #10678