add conditional smb trace logging for debug purposes #1150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
enhancement
3. to review
|
@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @jvillafanez, @PVince81 and @Xenopathic to be potential reviewers |
Member
|
imo this is useless, creates way to much noise without providing actual useful info and adds code complexity |
Member
|
=> Closing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@icewind1991 this adds logging information to smb when a config switch is set. Does it makes sense to you? Upstream backported this down to 9.0. Cf. owncloud/core#25758