Skip to content

Stable9 smb cherry-pciks #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LukasReschke wants to merge 17 commits into from
Closed

Stable9 smb cherry-pciks #1151

LukasReschke wants to merge 17 commits into from

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Aug 29, 2016

jvillafanez and others added 17 commits August 29, 2016 15:02
@jvillafanez @LukasReschke
Fix file permissions for SMB (read-only folders will be writeable) (#…
51d811d 
…25734)

Read-only folders won't be deletable
@butonic @LukasReschke
add conditional smb trace logging for debug purposes
f39a2f4
@butonic @LukasReschke
stat for root of a share does not work
fde188e
@butonic @LukasReschke
don't list hidden files
a6882ee
@butonic @LukasReschke
formatInfo should include type
981065c
@butonic @LukasReschke
overwrite target on rename
0d47c1b
@butonic @LukasReschke
use stat to determine has updated
f0ddca0
@butonic @LukasReschke
stat now handles mtime for root shares, simplify hasUpdated
bd5ee22
@butonic @LukasReschke
move share check to getFileInfo
d86d5bf
@butonic @LukasReschke
always try stat, fake if forbidden, actually return the fileinfo array
e79d00f
@butonic @LukasReschke
share root is always readable
9c32080
@butonic @LukasReschke
do not overwrite stat cache with plain array
acecb36
@butonic @LukasReschke
fix test execution due to connection limit
a5a222d
@butonic @LukasReschke
add dir based stat fallback
271c500
@butonic @LukasReschke
fix return values for smbclient backend
d371aaa 
see icewind1991/SMB@6e544f6
@butonic @LukasReschke
allow unhiding root folder in subfolder of share
0b7c8d3
@butonic @LukasReschke
trust libsmbclient on stat, only do dir fallback for smbclient
f1de117
@LukasReschke LukasReschke added 3. to review Waiting for reviews downstream labels Aug 29, 2016
@LukasReschke LukasReschke added this to the Nextcloud 9.0.54 milestone Aug 29, 2016
@mention-bot
Copy link

mention-bot commented Aug 29, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @butonic, @PVince81 and @Xenopathic to be potential reviewers

@icewind1991
Copy link
Member

icewind1991 commented Aug 30, 2016

👎 a lot of this is bad, I'll take some time to sort trough the changes later

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 1, 2016
@LukasReschke
Copy link
Member Author

LukasReschke commented Sep 14, 2016

@icewind1991 Any update?

@icewind1991 icewind1991 mentioned this pull request Oct 10, 2016
Merged
@icewind1991
Copy link
Member

icewind1991 commented Oct 10, 2016

#1678

@rullzer
Copy link
Member

rullzer commented Oct 19, 2016

@icewind1991 so this can be closed?

@icewind1991
Copy link
Member

icewind1991 commented Oct 20, 2016

Yes

@rullzer rullzer deleted the stable9-smb branch October 20, 2016 12:22
@yesiamdollar yesiamdollar mentioned this pull request Feb 6, 2024
Open
@0403350035 0403350035 mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 9.0.55

Development

Successfully merging this pull request may close these issues.

8 participants

@LukasReschke @mention-bot @icewind1991 @rullzer @MorrisJobke @jvillafanez @butonic