S3 reuse information from listObject and skip headObject #11518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Member
|
Code changes look good, but I would like to wait for the feedback of @icewind1991 here. |
icewind1991
previously requested changes
Oct 8, 2018
|
|
||
| $result = $this->headObject($path); | ||
| if (isset($result['ContentLength'])) { | ||
| return $result['ContentLength']; |
Member
There was a problem hiding this comment.
It would be nice if this would fill in the filesCache from the head response
Contributor
Author
There was a problem hiding this comment.
I've been thinking about that but headObject has already some internal cache. I think this would just add additional complexity. What do you think?
Signed-off-by: Daniel Kesselberg <[email protected]>
icewind1991
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed when looking into #6954 that there are many unneccessary headObject requests.
According to https://docs.aws.amazon.com/AmazonS3/latest/API/v2-RESTBucketGET.html#v2-RESTBucketGET-responses-examples Size, LastModified and Etag returned with listObjects.
When calling
statfor a file the required information are size and last modified. Reusing this information from listObjects may save some api calls.