Skip to content

Add uid_owner and uid_initiator share tabe indices #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 2, 2018
Merged

Add uid_owner and uid_initiator share tabe indices #11527

rullzer merged 1 commit into from
Oct 2, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 1, 2018

For #10926

@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Oct 1, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Oct 1, 2018
@rullzer rullzer merged commit ac8d4b2 into master Oct 2, 2018
@rullzer rullzer deleted the fix/10926/share_indexes branch October 2, 2018 15:16
@Arvidas
Copy link

Arvidas commented Nov 6, 2018

if (!$table->hasIndex('owner_index'))
not if (!$table->hasIndex('uid_owner')) {
and so on

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 6, 2018

if (!$table->hasIndex('owner_index'))
not if (!$table->hasIndex('uid_owner')) {
and so on

🙈

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 6, 2018

Thanks for spotting this.

MorrisJobke added a commit that referenced this pull request Nov 6, 2018
@MorrisJobke
Fix index names
30e0544 
* see #11527
MorrisJobke added a commit that referenced this pull request Nov 6, 2018
@MorrisJobke
Fix index names
4d20c42 
* see #11527
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 6, 2018

Fix is in #12312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @Arvidas @MorrisJobke @ChristophWurst