-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add occ app:remove CLI command #11627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d9469a6
Add occ app:remove CLI command
patschi c73363c
Fixed indents
patschi f8771d3
Run uninstall tasks by default, added '--keep-data' parameter
patschi f27ce6b
Inject AppManager and Installer, check for shipped app prior removing
patschi 1973556
Log exception using ILogger
patschi 4cd7cf8
Using Throwable instead of Exception
patschi 6a00521
Use error styling for exception message
patschi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| <?php | ||
| /** | ||
| * @copyright Copyright (c) 2018, Patrik Kernstock <info@pkern.at> | ||
| * | ||
| * @author Patrik Kernstock <info@pkern.at> | ||
| * | ||
| * @license AGPL-3.0 | ||
| * | ||
| * This code is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License, version 3, | ||
| * as published by the Free Software Foundation. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License, version 3, | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/> | ||
| * | ||
| */ | ||
|
|
||
| namespace OC\Core\Command\App; | ||
|
|
||
| use OC\Installer; | ||
| use Stecman\Component\Symfony\Console\BashCompletion\Completion\CompletionAwareInterface; | ||
| use Stecman\Component\Symfony\Console\BashCompletion\CompletionContext; | ||
| use Symfony\Component\Console\Command\Command; | ||
| use Symfony\Component\Console\Input\InputArgument; | ||
| use Symfony\Component\Console\Input\InputOption; | ||
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| class Remove extends Command implements CompletionAwareInterface { | ||
|
|
||
| protected function configure() { | ||
| $this | ||
| ->setName('app:remove') | ||
| ->setDescription('remove an app') | ||
| ->addArgument( | ||
| 'app-id', | ||
| InputArgument::REQUIRED, | ||
| 'remove the specified app' | ||
| ) | ||
| ->addOption( | ||
| 'keep-data', | ||
| null, | ||
| InputOption::VALUE_NONE, | ||
| 'keep app data and do not remove them' | ||
| ); | ||
| } | ||
|
|
||
| protected function execute(InputInterface $input, OutputInterface $output) { | ||
| $appId = $input->getArgument('app-id'); | ||
|
|
||
| if (!\OC_App::getAppPath($appId)) { | ||
| $output->writeln($appId . ' is not installed'); | ||
| return 1; | ||
| } | ||
|
|
||
| if (!$input->getOption('keep-data')) { | ||
| try { | ||
| /** @var IAppManager $appManager*/ | ||
| $appManager = \OC::$server->getAppManager(); | ||
| $appManager->disableApp($appId); | ||
| $output->writeln($appId . ' disabled'); | ||
| } catch(\Exception $e) { | ||
patschi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| $output->writeln('Error: ' . $e->getMessage()); | ||
patschi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return 1; | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| /** @var Installer $installer */ | ||
| $installer = \OC::$server->query(Installer::class); | ||
| $result = $installer->removeApp($appId); | ||
| } catch(\Exception $e) { | ||
patschi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| $output->writeln('Error: ' . $e->getMessage()); | ||
| return 1; | ||
| } | ||
|
|
||
| if($result === false) { | ||
| $output->writeln($appId . ' could not be removed'); | ||
| return 1; | ||
| } | ||
|
|
||
| $output->writeln($appId . ' removed'); | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| /** | ||
| * @param string $optionName | ||
| * @param CompletionContext $context | ||
| * @return string[] | ||
| */ | ||
| public function completeOptionValues($optionName, CompletionContext $context) { | ||
| return []; | ||
| } | ||
|
|
||
| /** | ||
| * @param string $argumentName | ||
| * @param CompletionContext $context | ||
| * @return string[] | ||
| */ | ||
| public function completeArgumentValues($argumentName, CompletionContext $context) { | ||
| if ($argumentName === 'app-id') { | ||
| return \OC_App::getAllApps(); | ||
patschi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| return []; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.