Remove deprecated SVG helpers for old IEs #11680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
Henni,
MorrisJobke,
juliusknorr and
rullzer
MorrisJobke
reviewed
Oct 8, 2018
| * @deprecated SVG is always supported (since 9.0) | ||
| * @return {boolean} true if the browser supports SVG, false otherwise | ||
| */ | ||
| hasSVGSupport: function(){ |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Same file for the other two methods.
MorrisJobke
approved these changes
Oct 8, 2018
rullzer
approved these changes
Oct 8, 2018
Member
|
Could you add this to #11045? |
This was referenced Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed long deprecated APIs and fixed usage (noops).
@MorrisJobke please double-check for any usage in 3rd party apps. Thanks!