[stable14] always query the lookup server in a global scale setup #11723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er label Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
nickvergessen
requested changes
Oct 10, 2018
| $body = json_decode($response->getBody(), true); | ||
|
|
||
| foreach ($body as $lookup) { | ||
| $remote = $this->cloudIdManager->resolveCloudId($lookup['federationId'])->getRemote(); |
Member
There was a problem hiding this comment.
resolveCloudId can throw, better wrap this in a try-catch too, so we get as many suggestions as possible?
|
|
||
| foreach ($body as $lookup) { | ||
| $remote = $this->cloudIdManager->resolveCloudId($lookup['federationId'])->getRemote(); | ||
| if ($this->currentUserRemote === $remote) continue; |
| foreach ($body as $lookup) { | ||
| $remote = $this->cloudIdManager->resolveCloudId($lookup['federationId'])->getRemote(); | ||
| if ($this->currentUserRemote === $remote) continue; | ||
| $name = isset($lookup['name']['value']) ? $lookup['name']['value'] : ''; |
Member
There was a problem hiding this comment.
Since we are now in php 7+ you can use:
$name = $lookup['name']['value'] ?? '';Signed-off-by: Bjoern Schiessle <[email protected]>
Member
|
let's finish master first? |
Member
Yes - let's close this for now and do the backport PR once master is accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #11714