Skip to content

Conversation

@Birkenstab
Copy link
Contributor

Fixes #11531

Although "same-origin" is more strict than e.g. strict-origin it triggers a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/

I guess the translations of the warning message will stop working.

Signed-off-by: Moritz Beck [email protected]

Fixes #11531

Although "same-origin" is more strict than e.g. strict-origin it showed up a warning in setupcheck
Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/

Signed-off-by: Moritz Beck <[email protected]>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep makes sense.

@rullzer rullzer added 3. to review Waiting for reviews backport-request labels Oct 11, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Oct 11, 2018
@rullzer
Copy link
Member

rullzer commented Oct 11, 2018

@Birkenstab thanks :)

The translations will be updated via transifex :)

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2018
@rullzer rullzer merged commit eed1e6e into nextcloud:master Oct 11, 2018
@Birkenstab Birkenstab deleted the feature/allow-same-origin-referrer-policy branch October 11, 2018 13:30
@MorrisJobke
Copy link
Member

@Birkenstab Mind to open the backport PR? This basically means you checkout stable14, branch off a new branch, use git cherry-pick to apply the commit from here to it and push that as a base for a pull request against stable14. ;)

@Birkenstab
Copy link
Contributor Author

@MorrisJobke Sure #11950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants