Skip to content

[stable14] Remove duplicate call to decodeURIComponent #11781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Oct 12, 2018
Merged

[stable14] Remove duplicate call to decodeURIComponent #11781

rullzer merged 1 commit into from
Oct 12, 2018

Conversation

@burned42
Copy link
Contributor

@burned42 burned42 commented Oct 11, 2018

Backported #11744 to stable14

@burned42
Remove duplicate call to decodeURIComponent
86b2e7d 
Signed-off-by: Bernd Stellwag <[email protected]>

(cherry picked from commit 0f030d8)
Signed-off-by: Bernd Stellwag <[email protected]>
@burned42 burned42 mentioned this pull request Oct 11, 2018
Merged
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 12, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14.0.4 milestone Oct 12, 2018
ChristophWurst
ChristophWurst approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2018
@juliusknorr
Copy link
Member

juliusknorr commented Oct 12, 2018

Failing postgres tests are likely unrelated, since it is a js only change:

https://drone.nextcloud.com/nextcloud/server/11426/151

@rullzer rullzer merged commit 59d5d48 into nextcloud:stable14 Oct 12, 2018
@MorrisJobke MorrisJobke mentioned this pull request Oct 16, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Nov 2, 2018
Closed
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug javascript

Projects

None yet

Milestone

Nextcloud 14.0.4

Development

Successfully merging this pull request may close these issues.

5 participants

@burned42 @juliusknorr @ChristophWurst @rullzer @MorrisJobke