Fix a case where "password_by_talk" was not a boolean #11802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0") and actively cast it to a boolean This was the error message that we have seen: ``` Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981 ``` Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
blizzz,
danxuliu,
nickvergessen and
rullzer
blizzz
approved these changes
Oct 12, 2018
Member
Author
|
I could only reproduce this by placing We maybe should look into this. For me it worked fine with |
Member
Author
Same after an upgrade from 13 to 14. |
Member
Author
|
Backport is in #11851 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(e.g. null or "0") and actively cast it to a boolean
This was the error message that we have seen:
Was added @danxuliu via dd0c5e2 (password via talk)