redirect to default app after solving the 2FA challenge #1188
Conversation
|
@ChristophWurst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen and @rullzer to be potential reviewers |
|
|
||
| $expected = new \OCP\AppFramework\Http\RedirectResponse('files/index/url'); | ||
| $this->assertEquals($expected, $this->controller->solveChallenge('myprovider', 'token')); | ||
| $this->assertInstanceOf('\OCP\AppFramework\Http\RedirectResponse', $this->controller->solveChallenge('myprovider', 'token')); |
There was a problem hiding this comment.
is there a way to reliably determine the output of OC_Util::getDefaultPageUrl() while testing? Then I could compare the actual return values here.
There was a problem hiding this comment.
I don't think so, but you can just make $expected use OC_Util::getDefaultPageUrl() as well. Not perfect, but works ;)
|
LGTM |
1 similar comment
|
LGTM |
|
This is a bug fix, so i guess we should backport this? cc @karlitschek @ChristophWurst Bug on |
|
stable9 doesnt have 2 factor, therefor the fix is different. |
|
I don't think this was backported, or at least I didn't do it |
|
@nickvergessen Ah of course, i mean stable10 |
|
@ChristophWurst @juliushaertl @nickvergessen Sorry, this was my fault. I posted a wrong version number in the forum. The correct version is 9.1.0.16. It works. Tank you! |
|
I think a backport makes sense! 👍 |
fixes nextcloud/twofactor_totp#52