Skip to content

Fix opening a section again in the Files app #11967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 3 commits into from
Oct 23, 2018
Merged

Fix opening a section again in the Files app #11967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
449349e
Fix opening a section again in the Files app
danxuliu Oct 19, 2018
0426ba6
Remove event handler no longer needed
danxuliu Oct 19, 2018
779000e
Add acceptance tests for opening a section in the Files app
danxuliu Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove event handler no longer needed 
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.

The file list for tags uses the handler for a different purpose, though,
so that one was kept.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Oct 21, 2018
commit 0426ba6de5c367a07414a5dbf54e1774d83d8803
6 changes: 0 additions & 6 deletions apps/files/js/favoritesfilelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,6 @@ $(document).ready(function() {

return OCA.Files.FileList.prototype.reloadCallback.call(this, status, result);
},

_onUrlChanged: function (e) {
if (e && _.isString(e.dir)) {
this.changeDirectory(e.dir, false, true);
}
}
});

OCA.Files.FavoritesFileList = FavoritesFileList;
Expand Down
6 changes: 0 additions & 6 deletions apps/files_sharing/js/sharedfilelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,12 +444,6 @@
// Sort by expected sort comparator
return files.sort(this._sortComparator);
},

_onUrlChanged: function(e) {
if (e && _.isString(e.dir)) {
this.changeDirectory(e.dir, false, true);
}
}
});

/**
Expand Down