-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
CalDAV calendar public sharing #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
69d3601
Proper work on Publishing
tcitworld 5824c24
Make little corrections
tcitworld 981c38f
Remove unnecessary implementation
tcitworld 1652a74
Fix publish-url property & getPublishStatus() fct
tcitworld 4a0e6e2
Remove unnecessary line
tcitworld f89961d
Fix annotations
tcitworld 72f35f8
Use ressource ID instead of name
tcitworld 7e5a82b
Use urlgenerator to generate an absolute url
tcitworld bd0aae8
No need to call database twice
tcitworld 8da2100
Start work on returning CalDAV published calendars
tcitworld 90ab6e4
Add new root collection public-calendars which holds all public calen…
DeepDiver1975 e7085aa
Allow not-authenticated access to specific urls
DeepDiver1975 00dc157
Fix requests for browser plugin as well as for the public calendar ro…
DeepDiver1975 994001c
Dirty hack to disable dav plugins on public calendar urls
tcitworld aca3053
Fix DB call for MySQL databases
tcitworld 2df69ec
correct get published status and minor fixes
tcitworld f09c46d
Fix some tests
tcitworld aadb56d
Fix wrong way to get publish status
tcitworld e783d01
Allow public access to the principals/system/public
DeepDiver1975 d0ec6b9
Disable OPTIONS handling - done by sabre
DeepDiver1975 77216e7
a few tests
tcitworld de5e212
fix plugin test
tcitworld ebf2377
fix unpublishing test
tcitworld 3921385
fix things (indentation, tests, comments, backend custom implementation
tcitworld 762726d
fix indent once and for all
tcitworld 1899116
move getPublicCalendar inside the caldav backend
tcitworld dd248ca
fix some bracket positions
tcitworld 691b3ab
Add publicuri to oc_dav_shares table and start working with it
tcitworld 9af2a9f
test serializer
tcitworld 8433c3c
fix getChild()
tcitworld a4fe596
add space between calendarname and owner name
tcitworld f16ea48
add can-be-published property
tcitworld f0421e1
add missing tests
tcitworld 6378dbc
fix can-be-published
tcitworld ad0eeaa
use AllowedSharingModes for can-be-published & can-be-shared
tcitworld 3e9a346
add calendarserver-sharing to the list of advertised features
tcitworld ff67cbc
Add test for PublicCalendarRoot
tcitworld 2fff203
Add missing constructor argument
LukasReschke 4659e3a
Add new constructor args
LukasReschke d884370
Use true random string as uri for public calendars - as a result we c…
DeepDiver1975 8360222
fix public calendars
tcitworld 17d5dfd
add in same request
tcitworld 9c75b00
fix tests
tcitworld dcc2311
fix annotations & copyright headers
tcitworld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Proper work on Publishing
- Loading branch information
commit 69d3601dcbb17ea9e2d868144159867a79d8e25c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| <?php | ||
|
|
||
| namespace OCA\DAV\CalDAV\Publishing; | ||
|
|
||
| //use OCA\DAV\CalDAV\Publishing\Xml; | ||
|
|
||
| use Sabre\DAV\PropFind; | ||
| use Sabre\DAV\INode; | ||
| use OCP\IRequest; | ||
| use Sabre\CalDAV\IShareableCalendar; | ||
| use Sabre\DAV\Server; | ||
| use Sabre\DAV\ServerPlugin; | ||
| use Sabre\HTTP\RequestInterface; | ||
| use Sabre\HTTP\ResponseInterface; | ||
| use OCA\DAV\CalDAV\Publishing\Xml\Publisher; | ||
|
|
||
| class PublishPlugin extends ServerPlugin | ||
| { | ||
| const NS_OWNCLOUD = 'http://owncloud.org/ns'; | ||
| const NS_CALENDARSERVER = 'http://calendarserver.org/ns/'; | ||
|
|
||
| /** | ||
| * Reference to SabreDAV server object. | ||
| * | ||
| * @var \Sabre\DAV\Server | ||
| */ | ||
| protected $server; | ||
|
|
||
| /** | ||
| * This method should return a list of server-features. | ||
| * | ||
| * This is for example 'versioning' and is added to the DAV: header | ||
| * in an OPTIONS response. | ||
| * | ||
| * @return string[] | ||
| */ | ||
| public function getFeatures() | ||
| { | ||
| return ['oc-calendar-publishing']; | ||
| } | ||
|
|
||
| /** | ||
| * Returns a plugin name. | ||
| * | ||
| * Using this name other plugins will be able to access other plugins | ||
| * using Sabre\DAV\Server::getPlugin | ||
| * | ||
| * @return string | ||
| */ | ||
| public function getPluginName() | ||
| { | ||
| return 'oc-calendar-publishing'; | ||
| } | ||
|
|
||
| /** | ||
| * This initializes the plugin. | ||
| * | ||
| * This function is called by Sabre\DAV\Server, after | ||
| * addPlugin is called. | ||
| * | ||
| * This method should set up the required event subscriptions. | ||
| * | ||
| * @param Server $server | ||
| */ | ||
| public function initialize(Server $server) | ||
| { | ||
| $this->server = $server; | ||
|
|
||
| $this->server->on('method:POST', [$this, 'httpPost']); | ||
| $this->server->on('propFind', [$this, 'propFind']); | ||
| } | ||
|
|
||
| function propFind(PropFind $propFind, INode $node) { | ||
| if ($node instanceof IShareableCalendar) { | ||
| $token = md5(\OC::$server->getConfig()->getSystemValue('secret','') . $node->getName()); | ||
| // $propFind->handle('{' . self::NS_CALENDARSERVER . '}publish-url', function() use ($node, $token) { | ||
| // return new Publisher($token); | ||
| // }); | ||
|
|
||
| $propFind->handle('{' . self::NS_CALENDARSERVER . '}pre-publish-url', function() use ($node, $token) { | ||
| if ($node->getPublishStatus()) { | ||
| return new Publisher($token); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * We intercept this to handle POST requests on calendars. | ||
| * | ||
| * @param RequestInterface $request | ||
| * @param ResponseInterface $response | ||
| * @return null|bool | ||
| */ | ||
| function httpPost(RequestInterface $request, ResponseInterface $response) { | ||
|
|
||
| $path = $request->getPath(); | ||
|
|
||
| // Only handling xml | ||
| $contentType = $request->getHeader('Content-Type'); | ||
| if (strpos($contentType, 'application/xml') === false && strpos($contentType, 'text/xml') === false) | ||
| return; | ||
|
|
||
| // Making sure the node exists | ||
| try { | ||
| $node = $this->server->tree->getNodeForPath($path); | ||
| } catch (DAV\Exception\NotFound $e) { | ||
| return; | ||
| } | ||
|
|
||
| $requestBody = $request->getBodyAsString(); | ||
|
|
||
| // If this request handler could not deal with this POST request, it | ||
| // will return 'null' and other plugins get a chance to handle the | ||
| // request. | ||
| // | ||
| // However, we already requested the full body. This is a problem, | ||
| // because a body can only be read once. This is why we preemptively | ||
| // re-populated the request body with the existing data. | ||
| $request->setBody($requestBody); | ||
|
|
||
| $message = $this->server->xml->parse($requestBody, $request->getUrl(), $documentType); | ||
|
|
||
| switch ($documentType) { | ||
|
|
||
|
|
||
| case '{' . self::NS_CALENDARSERVER . '}publish-calendar' : | ||
|
|
||
| // We can only deal with IShareableCalendar objects | ||
| if (!$node instanceof IShareableCalendar) { | ||
| return; | ||
| } | ||
| $this->server->transactionType = 'post-publish-calendar'; | ||
|
|
||
| // Getting ACL info | ||
| $acl = $this->server->getPlugin('acl'); | ||
|
|
||
| // If there's no ACL support, we allow everything | ||
| if ($acl) { | ||
| $acl->checkPrivileges($path, '{DAV:}write'); | ||
| } | ||
|
|
||
| $node->setPublishStatus(true); | ||
|
|
||
| // iCloud sends back the 202, so we will too. | ||
| $response->setStatus(202); | ||
|
|
||
| // Adding this because sending a response body may cause issues, | ||
| // and I wanted some type of indicator the response was handled. | ||
| $response->setHeader('X-Sabre-Status', 'everything-went-well'); | ||
|
|
||
| // Breaking the event chain | ||
| return false; | ||
|
|
||
| case '{' . self::NS_CALENDARSERVER . '}unpublish-calendar' : | ||
|
|
||
| // We can only deal with IShareableCalendar objects | ||
| if (!$node instanceof IShareableCalendar) { | ||
| return; | ||
| } | ||
| $this->server->transactionType = 'post-unpublish-calendar'; | ||
|
|
||
| // Getting ACL info | ||
| $acl = $this->server->getPlugin('acl'); | ||
|
|
||
| // If there's no ACL support, we allow everything | ||
| if ($acl) { | ||
| $acl->checkPrivileges($path, '{DAV:}write'); | ||
| } | ||
|
|
||
| $node->setPublishStatus(false); | ||
|
|
||
| $response->setStatus(200); | ||
|
|
||
| // Adding this because sending a response body may cause issues, | ||
| // and I wanted some type of indicator the response was handled. | ||
| $response->setHeader('X-Sabre-Status', 'everything-went-well'); | ||
|
|
||
| // Breaking the event chain | ||
| return false; | ||
|
|
||
| } | ||
|
|
||
|
|
||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?php | ||
|
|
||
| namespace OCA\DAV\CalDAV\Publishing\Xml; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing header |
||
|
|
||
| use OCA\DAV\CalDAV\Publishing\PublishPlugin as Plugin; | ||
| use Sabre\Xml\Writer; | ||
| use Sabre\Xml\XmlSerializable; | ||
|
|
||
| class Publisher implements XmlSerializable { | ||
|
|
||
| /** | ||
| * @var $publishUrl | ||
| */ | ||
| protected $publishUrl; | ||
|
|
||
| /** | ||
| * @param str $publishUrl | ||
| */ | ||
| function __construct($publishUrl) { | ||
| $this->publishUrl = $publishUrl; | ||
| } | ||
|
|
||
| /** | ||
| * @return str | ||
| */ | ||
| function getValue() { | ||
| return $this->publishUrl; | ||
| } | ||
|
|
||
| /** | ||
| * The xmlSerialize metod is called during xml writing. | ||
| * | ||
| * Use the $writer argument to write its own xml serialization. | ||
| * | ||
| * An important note: do _not_ create a parent element. Any element | ||
| * implementing XmlSerializble should only ever write what's considered | ||
| * its 'inner xml'. | ||
| * | ||
| * The parent of the current element is responsible for writing a | ||
| * containing element. | ||
| * | ||
| * This allows serializers to be re-used for different element names. | ||
| * | ||
| * If you are opening new elements, you must also close them again. | ||
| * | ||
| * @param Writer $writer | ||
| * @return void | ||
| */ | ||
| function xmlSerialize(Writer $writer) { | ||
|
|
||
| $cs = '{' . Plugin::NS_CALENDARSERVER . '}'; | ||
| $writer->write($this->publishUrl); | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing copyright