Skip to content

Conversation

@MorrisJobke
Copy link
Member

Before it quit right after finding the theme version of the l10n file which results in a not translated part of the UI.

How to reproduce:

  • create themes/test/apps/files/l10n/de.js with this:
OC.L10N.register(
	"files",
	{
		"Download" : "Herunterladen2"
	},
	"nplurals=2; plural=(n != 1);"
);
  • create themes/test/apps/files/l10n/de.json with this:
{
  "translations": {
    "Download" : "Herunterladen2"
  },
  "pluralForm" :"nplurals=2; plural=(n != 1);"
}
  • configure the theme test in config.php
  • configure the user to have `Deutsch (Persönlich: Du)" as language
  • before: in the files app -> 3 dots menu is not properly translated:

bildschirmfoto 2018-10-22 um 11 06 19

  • after: in the files app -> 3 dots menu is properly translated:

bildschirmfoto 2018-10-22 um 11 06 03

I would like to backport this to 13, because it was reported there.

Before it quit right after finding the theme version of the l10n file which results in a not translated part of the UI.

Signed-off-by: Morris Jobke <[email protected]>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about custom apps dir?

@MorrisJobke
Copy link
Member Author

What about custom apps dir?

Wasn't included before. And I don't want to mess to bad with this for now. This solved the issues we had for now and we should maybe look into how to make this independent from a theme maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants