Skip to content

[stable13] Fix opening a section again in the Files app #11996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 3 commits into from
Oct 23, 2018
Merged

[stable13] Fix opening a section again in the Files app #11996

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f5b072
Fix opening a section again in the Files app
danxuliu Oct 19, 2018
bc7e8cb
Remove event handler no longer needed
danxuliu Oct 19, 2018
3fbb6e7
Add acceptance tests for opening a section in the Files app
danxuliu Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add acceptance tests for opening a section in the Files app 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Oct 23, 2018
commit 3fbb6e70344116ef3b11c1f8114e8613f3172539
72 changes: 72 additions & 0 deletions tests/acceptance/features/app-files.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,78 @@ Feature: app-files
When I open the details view for "welcome.txt"
Then I see that the details view for "All files" section is open

Scenario: show recent files
Given I am logged in
And I create a new folder named "Folder just created"
When I open the "Recent" section
Then I see that the current section is "Recent"
Then I see that the file list contains a file named "Folder just created"

Scenario: show recent files for a second time
Given I am logged in
And I open the "Recent" section
And I see that the current section is "Recent"
And I open the "All files" section
And I see that the current section is "All files"
And I create a new folder named "Folder just created"
When I open the "Recent" section
Then I see that the current section is "Recent"
Then I see that the file list contains a file named "Folder just created"

Scenario: show favorites
Given I am logged in
And I mark "welcome.txt" as favorite
When I open the "Favorites" section
Then I see that the current section is "Favorites"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show favorites for a second time
Given I am logged in
And I open the "Favorites" section
And I see that the current section is "Favorites"
And I open the "All files" section
And I see that the current section is "All files"
And I mark "welcome.txt" as favorite
When I open the "Favorites" section
Then I see that the current section is "Favorites"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show shares
Given I am logged in
And I share the link for "welcome.txt"
When I open the "Shared by link" section
Then I see that the current section is "Shared by link"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show shares for a second time
Given I am logged in
And I open the "Shared by link" section
And I see that the current section is "Shared by link"
And I open the "All files" section
And I see that the current section is "All files"
And I share the link for "welcome.txt"
When I open the "Shared by link" section
Then I see that the current section is "Shared by link"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show deleted files
Given I am logged in
And I delete "welcome.txt"
When I open the "Deleted files" section
Then I see that the current section is "Deleted files"
Then I see that the file list contains a file named "welcome.txt"

Scenario: show deleted files for a second time
Given I am logged in
And I open the "Deleted files" section
And I see that the current section is "Deleted files"
And I open the "All files" section
And I see that the current section is "All files"
And I delete "welcome.txt"
When I open the "Deleted files" section
Then I see that the current section is "Deleted files"
Then I see that the file list contains a file named "welcome.txt"

Scenario: rename a file with the details view open
Given I am logged in
And I open the details view for "welcome.txt"
Expand Down
16 changes: 16 additions & 0 deletions tests/acceptance/features/bootstrap/FileListContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,13 @@ public static function viewFileInFolderMenuItem() {
return self::fileActionsMenuItemFor("View in folder");
}

/**
* @return Locator
*/
public static function deleteMenuItem() {
return self::fileActionsMenuItemFor("Delete");
}

/**
* @Given I create a new folder named :folderName
*/
Expand Down Expand Up @@ -322,6 +329,15 @@ public function iViewInFolder($fileName) {
$this->actor->find(self::viewFileInFolderMenuItem(), 2)->click();
}

/**
* @When I delete :fileName
*/
public function iDelete($fileName) {
$this->actor->find(self::fileActionsMenuButtonForFile($this->fileListAncestor, $fileName), 10)->click();

$this->actor->find(self::deleteMenuItem(), 2)->click();
}

/**
* @Then I see that the file list is eventually loaded
*/
Expand Down