Skip to content

Move acceptance tests that crash the PHP built-in server to Apache #12104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 3 commits into from
Oct 29, 2018
Merged

Move acceptance tests that crash the PHP built-in server to Apache #12104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95dc2ad
Extract acceptance tests for tags to their own feature file
danxuliu Oct 28, 2018
34f397f
Link the default Apache directory to the Nextcloud server in all runners
danxuliu Oct 29, 2018
565556b
Move acceptance tests that crash the PHP built-in server to Apache
danxuliu Oct 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move acceptance tests that crash the PHP built-in server to Apache 
The PHP built-in server can crash when certain actions are performed in
Nextcloud (but although the crash is triggered by Nextcloud it does not
seem to be a Nextcloud bug), which can lead to failures in the
acceptance tests that would have otherwise passed.

A crash of the PHP built-in server during an acceptance test can be
identified by the message "sh: 1: kill: No such process" in the
acceptance tests output; as the PHP built-in server crashed its process
does no longer exist when it is tried to be killed when the scenario
ends.

Although the crash has been observed in other tests too it is more
prevalent in the tests for tags and the theming app. In order to
reduce the false positives those tests are now run on Apache instead of
on the PHP built-in sever. However, the rest of tests are still run on
the PHP built-in server due to its lower resource consumption.

In order to run a feature or just a scenario using Apache it has to be
tagged with "@apache"; features or scenarios without that tag (the
default) will run on the PHP built-in server instead.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Oct 29, 2018
commit 565556b277bae659d15a949cd4e17effdb77b483
28 changes: 28 additions & 0 deletions tests/acceptance/config/behat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,34 @@ default:
- SettingsMenuContext
- ThemingAppContext
- UsersSettingsContext
filters:
tags: "~@apache"
apache:
paths:
- %paths.base%/../features
contexts:
- ActorContext
- NextcloudTestServerContext:
nextcloudTestServerHelper: NextcloudTestServerLocalApacheHelper

- AppNavigationContext
- AppSettingsContext
- AppsManagementContext
- CommentsAppContext
- ContactsMenuContext
- DialogContext
- FeatureContext
- FileListContext
- FilesAppContext
- FilesSharingAppContext
- LoginPageContext
- NotificationContext
- SettingsContext
- SettingsMenuContext
- ThemingAppContext
- UsersSettingsContext
filters:
tags: "@apache"
extensions:
Behat\MinkExtension:
sessions:
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/app-files-tags.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@apache
Feature: app-files-tags

Scenario: show the input field for tags in the details view
Expand Down
1 change: 1 addition & 0 deletions tests/acceptance/features/app-theming.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@apache
Feature: app-theming

Scenario: changing the color updates the header color
Expand Down