Skip to content

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 29, 2018

fixes #12086

@jlehtoranta @MrManor @PaulLebmann this should fix the issue as you described it. Would be great if you can test and confirm it is working again.

@MrManor
Copy link

MrManor commented Oct 29, 2018

Works for me! Thanks. (Only one file DL and tested as have have no user_ldap/tests catalog in my install)

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@MorrisJobke MorrisJobke merged commit 76c3185 into master Oct 29, 2018
@MorrisJobke MorrisJobke deleted the fix/12086/no-unintentional-empty-attributes branch October 29, 2018 16:00
@violoncelloCH
Copy link
Member

violoncelloCH commented Oct 29, 2018

should this be backported to 14 stable? #12086 seems to make it impossible to use Nextcloud in combination with these LDAP-Servers. Or is the range of users affected small enough?
sorry, overlooked the label

@MorrisJobke
Copy link
Member

should this be backported to 14 stable? #12086 seems to make it impossible to use Nextcloud in combination with these LDAP-Servers. Or is the range of users affected small enough?

Yes - we already added the backport-request label and this will be back ported within the next days. 👍

@blizzz
Copy link
Member Author

blizzz commented Oct 29, 2018

backport PRs are opened

@kesselb
Copy link
Contributor

kesselb commented Oct 29, 2018

Is 0 a valid value for ldapQuotaAttribute? empty(0) would evaluate to true.

@blizzz
Copy link
Member Author

blizzz commented Oct 29, 2018

Is 0 a valid value for ldapQuotaAttribute? empty(0) would evaluate to true.

If I understand it correctly, an attribute's name at least is one UTF-8 character, so "0" seems possible. However, it is beyond practice to use numbers as attribute names, especially 0 → it is not relevant.

@PaulLebmann
Copy link

Works for me too! Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LDAP is not working with the latest 389 Directory Server

8 participants