Design details in file picker #12154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
added
bug
design
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Member
Strange, it works fine here! :)
|
skjnldsv
approved these changes
Oct 31, 2018
skjnldsv
added
4. to release
Member
Author
I did of course try the same. ;) But note how there’s only border-radius on the top of the image. Because the image starts at the top of the td, but it ends before the bottom, cause the filename is in the same td element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The centering of text because it’s centered in the Files view too – check with short names. :) And the filename was too closely stuck below the thumbnail.
And the rounding off of thumbnails does not work in the file picker as of now unfortunately because we use background-image there for the thumbnail. (We should change this when we do a rewrite.)
Before and after of file picker grid view:
Please review @nextcloud/designers ❤️