Skip to content

Allow to validate the password_policy app #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Sep 2, 2016
Merged

Allow to validate the password_policy app #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow to validate the password_policy app
  • Loading branch information
@nickvergessen
nickvergessen committed Sep 1, 2016
commit de96c5b17b72b0cd174dc1cfddc5ae3c1f94d81d
12 changes: 9 additions & 3 deletions lib/private/App/CodeChecker/CodeChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,25 @@ public function analyse($appId) {
throw new \RuntimeException("No app with given id <$appId> known.");
}

return $this->analyseFolder($appPath);
return $this->analyseFolder($appId, $appPath);
}

/**
* @param string $appId
* @param string $folder
* @return array
*/
public function analyseFolder($folder) {
public function analyseFolder($appId, $folder) {
$errors = [];

$excludedDirectories = ['vendor', '3rdparty', '.git', 'l10n', 'tests', 'test'];
if ($appId === 'password_policy') {
$excludedDirectories[] = 'lists';
}

$excludes = array_map(function($item) use ($folder) {
return $folder . '/' . $item;
}, ['vendor', '3rdparty', '.git', 'l10n', 'tests', 'test']);
}, $excludedDirectories);

$iterator = new RecursiveDirectoryIterator($folder, RecursiveDirectoryIterator::SKIP_DOTS);
$iterator = new RecursiveCallbackFilterIterator($iterator, function($item) use ($folder, $excludes){
Expand Down