avoid logging of "Partial search results returned: Sizelimit exceeded…" #12292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
GitHubUser4234,
MorrisJobke,
juliusknorr and
rullzer
This was referenced Nov 5, 2018
… at" LDAP servers respond with that even if a limit was passed with the request. Having this statement logged causes a lot of confusion. Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/2947/lapse-sizelimit-error
branch
from
931946f to
deec5a7
Compare
Member
|
@rullzer Mind to review this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a search request containing a limit is sent against an LDAP server, most will sent the message as in $subject along with the results. The LDAP PHP module triggers this as an PHP error, thus ending up through our error handler in the Nextcloud log.
While not being an error in itself, often admins perceive this as confusing, ending up in several requests not only in this issue tracker. Hence, it would be nice to filter out this message, like this PR does. Fixes #2947
An alternative approach would be to open up our internal error handler from core to app specific proceedings.
How to test:
Before the patch, the mentioned error message would be written. Now it is not supposed to happen anymore.