Skip to content

Add grid toggle for every files view #12303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Nov 6, 2018
Merged

Add grid toggle for every files view #12303

skjnldsv merged 3 commits into from
Nov 6, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 6, 2018

Fix #12214

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Nov 6, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 6, 2018
@skjnldsv skjnldsv self-assigned this Nov 6, 2018
@skjnldsv skjnldsv force-pushed the grid-for-all-file-templates branch from a069840 to 095b88a Compare November 6, 2018 09:10
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 6, 2018 •
edited by skjnldsv
Loading

@rullzer
Copy link
Member

rullzer commented Nov 6, 2018

For the second screenshot @jancborchardt also has an issue. I guess the wrong (small) preview is requested

@skjnldsv
Add grid toggle for every files view
5682d30 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the grid-for-all-file-templates branch from 095b88a to 5682d30 Compare November 6, 2018 10:42
@skjnldsv
Fix min trhumbnail size
98edf36 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 6, 2018

All fixed

juliusknorr
juliusknorr requested changes Nov 6, 2018
View reviewed changes
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
Merged
29 tasks
MorrisJobke
MorrisJobke approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@juliusknorr
Copy link
Member

juliusknorr commented Nov 6, 2018

@skjnldsv One unit test failure:


There was 1 failure:

1) OCA\Files\Tests\Controller\ViewControllerTest::testIndexWithRegularBrowser
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
+        'showgridview' => null
+        'isIE' => false

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 6, 2018
@skjnldsv
Fix tests
cac2f7f 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the grid-for-all-file-templates branch from 7cd38ec to cac2f7f Compare November 6, 2018 15:05
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 6, 2018

Unrelated: sh: 1: kill: No such process

@skjnldsv skjnldsv merged commit e03bc6e into master Nov 6, 2018
@skjnldsv skjnldsv deleted the grid-for-all-file-templates branch November 6, 2018 16:29
@danxuliu danxuliu mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @MorrisJobke @rullzer @juliusknorr